Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable: fix information_schema.VARIABLES_INFO DEFAULT_VALUE not right problem (#49524) #50336

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #49524

What problem does this PR solve?

Issue Number: close #49461, close #49968, close #50155

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Without this pr, deploy a cluster:

mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where DEFAULT_VALUE != CURRENT_VALUE and variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
+-----------------------------------+----------------+---------------+---------------+
| VARIABLE_NAME                     | VARIABLE_SCOPE | DEFAULT_VALUE | CURRENT_VALUE |
+-----------------------------------+----------------+---------------+---------------+
| tidb_row_format_version           | SESSION,GLOBAL | 1             | 2             |
| tidb_pessimistic_txn_fair_locking | SESSION,GLOBAL | OFF           | ON            |
| tidb_enable_async_commit          | SESSION,GLOBAL | OFF           | ON            |
| tidb_enable_mutation_checker      | SESSION,GLOBAL | OFF           | ON            |
| tidb_txn_mode                     | SESSION,GLOBAL |               | pessimistic   |
| tidb_txn_assertion_level          | SESSION,GLOBAL | OFF           | FAST          |
| tidb_enable_1pc                   | SESSION,GLOBAL | OFF           | ON            |
+-----------------------------------+----------------+---------------+---------------+
7 rows in set (0.07 sec)

With this pr:


mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where DEFAULT_VALUE != CURRENT_VALUE and variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
Empty set (0.01 sec)


mysql> select VARIABLE_NAME, VARIABLE_SCOPE, DEFAULT_VALUE, CURRENT_VALUE from information_schema.VARIABLES_INFO where variable_name in ('tidb_txn_mode', 'tidb_enable_async_commit','tidb_enable_1pc', 'tidb_mem_oom_action', 'tidb_enable_auto_analyze', 'tidb_row_format_version', 'tidb_txn_assertion_level', 'tidb_enable_mutation_checker', 'tidb_pessimistic_txn_fair_locking');
+-----------------------------------+----------------+---------------+---------------+
| VARIABLE_NAME                     | VARIABLE_SCOPE | DEFAULT_VALUE | CURRENT_VALUE |
+-----------------------------------+----------------+---------------+---------------+
| tidb_mem_oom_action               | GLOBAL         | CANCEL        | CANCEL        |
| tidb_enable_1pc                   | SESSION,GLOBAL | ON            | ON            |
| tidb_enable_async_commit          | SESSION,GLOBAL | ON            | ON            |
| tidb_enable_auto_analyze          | GLOBAL         | ON            | ON            |
| tidb_row_format_version           | SESSION,GLOBAL | 2             | 2             |
| tidb_txn_mode                     | SESSION,GLOBAL | pessimistic   | pessimistic   |
| tidb_pessimistic_txn_fair_locking | SESSION,GLOBAL | ON            | ON            |
| tidb_txn_assertion_level          | SESSION,GLOBAL | FAST          | FAST          |
| tidb_enable_mutation_checker      | SESSION,GLOBAL | ON            | ON            |
+-----------------------------------+----------------+---------------+---------------+
9 rows in set (0.01 sec)

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fix the behavior to show the right default value for some variables

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot requested a review from a team as a code owner January 11, 2024 10:54
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 26, 2024
@ti-chi-bot ti-chi-bot closed this Feb 26, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 27, 2024
Copy link

ti-chi-bot bot commented Feb 27, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YangKeao
Copy link
Member

I don't know why it's closed previously. Re-open it now.

@YangKeao YangKeao reopened this Apr 12, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 12, 2024
Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the cherry-pick-49524-to-release-7.1 branch from c4908e5 to 79bdcd4 Compare April 17, 2024 07:02
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 18, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2024
Copy link

ti-chi-bot bot commented Oct 11, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 8bd7b23 link true /test unit-test
idc-jenkins-ci-tidb/check_dev 8bd7b23 link true /test check-dev
idc-jenkins-ci-tidb/mysql-test 8bd7b23 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev_2 8bd7b23 link true /test check-dev2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 28, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 6, 2024
Copy link

ti-chi-bot bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Nov 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-06 05:23:29.252678222 +0000 UTC m=+1018522.091833769: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Nov 6, 2024
@ti-chi-bot ti-chi-bot closed this Nov 11, 2024
Copy link

ti-chi-bot bot commented Nov 11, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/cherry-pick-not-approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants