Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec: encode checksum for timestamp consider tz (#50896) #50929

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50896

What problem does this PR solve?

Issue Number: close #50851

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix row checksum calculation on the timestamp does not consider time zone cause the CDC failed to verify the checksum

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Feb 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 2, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 2, 2024
Copy link

ti-chi-bot bot commented Feb 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-02 10:21:22.465304612 +0000 UTC m=+1733724.029602316: ☑️ agreed by zyguan.
  • 2024-02-02 10:41:49.561353783 +0000 UTC m=+1734951.125651489: ☑️ agreed by cfzjywxk.

Copy link

ti-chi-bot bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, tangenta, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Feb 2, 2024
@3AceShowHand
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 40f51ca into pingcap:release-7.5 Feb 2, 2024
16 checks passed
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.5@ecfef69). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #50929   +/-   ##
================================================
  Coverage               ?   71.9817%           
================================================
  Files                  ?       1402           
  Lines                  ?     406803           
  Branches               ?          0           
================================================
  Hits                   ?     292824           
  Misses                 ?      94276           
  Partials               ?      19703           
Flag Coverage Δ
unit 71.9817% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9913% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.2817% <0.0000%> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants