Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec: encode checksum for timestamp consider tz (#50896) #50930

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50896

What problem does this PR solve?

Issue Number: close #50851

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix row checksum calculation on the timestamp does not consider time zone cause the CDC failed to verify the checksum

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Feb 2, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 26, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@25f0109). Click here to learn what that means.
The diff coverage is 70.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50930   +/-   ##
================================================
  Coverage               ?   73.4075%           
================================================
  Files                  ?       1209           
  Lines                  ?     378845           
  Branches               ?          0           
================================================
  Hits                   ?     278101           
  Misses                 ?      82980           
  Partials               ?      17764           

Copy link

ti-chi-bot bot commented Feb 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wjhuang2016, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2024
Copy link

ti-chi-bot bot commented Feb 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-26 09:17:33.604835185 +0000 UTC m=+867142.352458296: ☑️ agreed by zyguan.
  • 2024-02-26 09:50:00.347092714 +0000 UTC m=+869089.094715826: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit a26af5f into pingcap:release-7.1 Feb 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants