-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: skip fresh check when user has specified --filter in restore full #51010
Conversation
Skipping CI for Draft Pull Request. |
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51010 +/- ##
================================================
+ Coverage 72.2813% 72.6489% +0.3675%
================================================
Files 1467 1467
Lines 361854 434919 +73065
================================================
+ Hits 261553 315964 +54411
- Misses 80989 99019 +18030
- Partials 19312 19936 +624
Flags with carried forward coverage won't be shown. Click here to find out more.
|
br/pkg/task/restore.go
Outdated
// we need check cluster is fresh every time. except restore from a checkpoint. | ||
if client.IsFull() && len(checkpointSetWithTableID) == 0 { | ||
// we need check cluster is fresh every time. except restore from a checkpoint or user has not set filter argument. | ||
if client.IsFull() && !cfg.ExplicitFilter && len(checkpointSetWithTableID) == 0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a case. Other LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BornChanger, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #51009
Problem Summary:
In previous when user doing a full restore. we add a check to make sure the cluster must be empty. but sometime user want to do a full restore with --filter. at that time we should not check the empty cluster anymore.
What changed and how does it work?
This PR skip the check when user has set the --filter argument manually.
Check List
Tests
Unit test
Integration test
Manual test (add detailed scripts or steps below)
before this PR
after this PR
No need to test
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.