Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: split InfoSchemaMisc from InfoSchema interface #51015

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

tiancaiamao
Copy link
Contributor

@tiancaiamao tiancaiamao commented Feb 6, 2024

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Split the InfoSchema into two, the core APIs and InfoSchemaMisc.
In InfoSchemaV2, we'll still use the same InfoSchemaMisc implementation.
This cleanup is a furthur step to make our InfoSchemaV2 easier.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

No functional changes.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2024
Copy link

tiprow bot commented Feb 6, 2024

Hi @tiancaiamao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Merging #51015 (647ca78) into master (f5e0799) will increase coverage by 0.3712%.
Report is 1 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51015        +/-   ##
================================================
+ Coverage   72.2813%   72.6525%   +0.3712%     
================================================
  Files          1467       1467                
  Lines        361854     434915     +73061     
================================================
+ Hits         261553     315977     +54424     
- Misses        80989      99008     +18019     
- Partials      19312      19930       +618     
Flag Coverage Δ
integration 49.2099% <91.6666%> (?)
unit 70.3058% <100.0000%> (-1.8496%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 54.1120% <ø> (-2.3651%) ⬇️
parser ∅ <ø> (∅)
br 51.2942% <ø> (+5.0077%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 7, 2024
Copy link

ti-chi-bot bot commented Feb 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-07 02:48:11.220392511 +0000 UTC m=+325016.787162401: ☑️ agreed by lcwangchao.
  • 2024-02-07 05:36:41.927223962 +0000 UTC m=+335127.493993849: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot bot merged commit f46bded into pingcap:master Feb 7, 2024
21 checks passed
@tiancaiamao tiancaiamao deleted the infoschema-misc branch February 7, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants