-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema: split InfoSchemaMisc from InfoSchema interface #51015
Conversation
Hi @tiancaiamao. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51015 +/- ##
================================================
+ Coverage 72.2813% 72.6525% +0.3712%
================================================
Files 1467 1467
Lines 361854 434915 +73061
================================================
+ Hits 261553 315977 +54424
- Misses 80989 99008 +18019
- Partials 19312 19930 +618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lcwangchao, ywqzzy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
What changed and how does it work?
Split the InfoSchema into two, the core APIs and InfoSchemaMisc.
In InfoSchemaV2, we'll still use the same InfoSchemaMisc implementation.
This cleanup is a furthur step to make our InfoSchemaV2 easier.
Check List
Tests
No functional changes.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.