Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade staticcheck #51266

Merged
merged 2 commits into from
Feb 23, 2024
Merged

*: upgrade staticcheck #51266

merged 2 commits into from
Feb 23, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 23, 2024

What problem does this PR solve?

Issue Number: ref #50765

Problem Summary:

What changed and how does it work?

The latest version should no longer panic when checking code targeting Go 1.22.

image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <hawking.rei@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 23, 2024
@hawkingrei
Copy link
Member Author

/retest

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Merging #51266 (8a0fa4d) into master (1d68ada) will decrease coverage by 15.7759%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51266         +/-   ##
=================================================
- Coverage   70.6316%   54.8558%   -15.7759%     
=================================================
  Files          1457       1568        +111     
  Lines        433858     610178     +176320     
=================================================
+ Hits         306441     334718      +28277     
- Misses       108131     251805     +143674     
- Partials      19286      23655       +4369     
Flag Coverage Δ
integration 37.1522% <ø> (?)
unit 70.5091% <ø> (+0.0901%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4967% <ø> (+5.6676%) ⬆️

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 23, 2024
Copy link

ti-chi-bot bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, hi-rustin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Defined2014,hi-rustin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 23, 2024
Copy link

ti-chi-bot bot commented Feb 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-23 06:44:31.715848079 +0000 UTC m=+598760.463471182: ☑️ agreed by hi-rustin.
  • 2024-02-23 07:06:13.857457803 +0000 UTC m=+600062.605080899: ☑️ agreed by Defined2014.

@ti-chi-bot ti-chi-bot bot merged commit 625eded into pingcap:master Feb 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants