Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema: refine common part for builder #51411

Merged
merged 10 commits into from
Mar 1, 2024

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Feb 29, 2024

What problem does this PR solve?

Issue Number: ref #50959

Problem Summary:

What changed and how does it work?

Extract some common part for v1 and v2 for future development.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 29, 2024
Copy link

tiprow bot commented Feb 29, 2024

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Merging #51411 (284a8ba) into master (718c7a3) will increase coverage by 2.1226%.
Report is 7 commits behind head on master.
The diff coverage is 87.3563%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51411        +/-   ##
================================================
+ Coverage   70.7479%   72.8705%   +2.1226%     
================================================
  Files          1462       1462                
  Lines        435179     435740       +561     
================================================
+ Hits         307880     317526      +9646     
+ Misses       108058      98260      -9798     
- Partials      19241      19954       +713     
Flag Coverage Δ
integration 48.9140% <75.8620%> (?)
unit 70.5268% <83.9080%> (-0.0256%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4102% <ø> (+5.5296%) ⬆️

@ywqzzy ywqzzy changed the title [WIP]infoschema: Split common part for builder infoschema: refine common part for builder Feb 29, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Feb 29, 2024
Copy link
Contributor

@tiancaiamao tiancaiamao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure

func init() {
	enableV2.Store(true)
}

tidb-server start up does not panic, otherwise this is broken PR

@ywqzzy
Copy link
Contributor Author

ywqzzy commented Feb 29, 2024

Please make sure

func init() {
	enableV2.Store(true)
}

tidb-server start up does not panic, otherwise this is broken PR

OK

image

@tiancaiamao
Copy link
Contributor

Please resolve conflict @ywqzzy

@ywqzzy ywqzzy requested a review from tiancaiamao March 1, 2024 03:12
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 1, 2024
Copy link

ti-chi-bot bot commented Mar 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 04:00:32.615287479 +0000 UTC m=+1193721.362910611: ☑️ agreed by GMHDBJD.
  • 2024-03-01 06:58:23.584777658 +0000 UTC m=+1204392.332400770: ☑️ agreed by tiancaiamao.

@ti-chi-bot ti-chi-bot bot merged commit da7cd99 into pingcap:master Mar 1, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants