Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain: avoid panic in the init stats breaking the loadStatsWorker #51579

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Mar 7, 2024

What problem does this PR solve?

Issue Number: close #51581

Problem Summary:

What changed and how does it work?

If init-stats panics, then the load stats of this instance will all be broken.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Mar 7, 2024
pkg/domain/domain.go Outdated Show resolved Hide resolved
pkg/domain/domain.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #51579 (1759b7a) into master (f94a6ba) will increase coverage by 2.1003%.
Report is 1 commits behind head on master.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51579        +/-   ##
================================================
+ Coverage   70.7853%   72.8856%   +2.1003%     
================================================
  Files          1467       1467                
  Lines        436397     436418        +21     
================================================
+ Hits         308905     318086      +9181     
+ Misses       108156      98376      -9780     
- Partials      19336      19956       +620     
Flag Coverage Δ
integration 48.8362% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.4629% <ø> (+5.5714%) ⬆️

Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 7, 2024
Copy link

ti-chi-bot bot commented Mar 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-07 06:34:22.281691666 +0000 UTC m=+321689.303938055: ☑️ agreed by AilinKid.
  • 2024-03-07 07:07:23.399735506 +0000 UTC m=+323670.421981894: ☑️ agreed by elsa0520.

@hawkingrei
Copy link
Member Author

/retest

Copy link

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 7, 2024
@ti-chi-bot ti-chi-bot bot merged commit d389099 into pingcap:master Mar 7, 2024
23 checks passed
@ti-chi-bot ti-chi-bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Mar 14, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #51754.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #51755.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #51756.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic in the init stats will break the loadStatsWorker
5 participants