Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: always upload md5 to aws s3 #51714

Closed
wants to merge 1 commit into from
Closed

Conversation

RidRisR
Copy link
Contributor

@RidRisR RidRisR commented Mar 12, 2024

What problem does this PR solve?

Issue Number: close #51184
Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Mar 12, 2024
Copy link

ti-chi-bot bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yujuncen for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Mar 12, 2024
Copy link

tiprow bot commented Mar 12, 2024

Hi @RidRisR. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Merging #51714 (23419c2) into master (cd6dbc2) will increase coverage by 1.9326%.
The diff coverage is 0.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51714        +/-   ##
================================================
+ Coverage   70.7528%   72.6854%   +1.9325%     
================================================
  Files          1474       1474                
  Lines        437068     437100        +32     
================================================
+ Hits         309238     317708      +8470     
+ Misses       108489      99352      -9137     
- Partials      19341      20040       +699     
Flag Coverage Δ
integration 48.2527% <0.0000%> (?)
unit 70.4831% <0.0000%> (-0.0848%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.1851% <0.0000%> (+5.2903%) ⬆️

@ywqzzy ywqzzy requested a review from lance6716 March 13, 2024 02:05
@lance6716
Copy link
Contributor

/cc @YuJuncen

@ti-chi-bot ti-chi-bot bot requested a review from YuJuncen March 13, 2024 02:20
@RidRisR RidRisR closed this Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pitr: support log backup to s3 when object lock is enabled
2 participants