-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restore: use a limited workpool #51872
Conversation
Skipping CI for Draft Pull Request. |
Hi @3pointer. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51872 +/- ##
=================================================
- Coverage 70.7104% 55.0900% -15.6204%
=================================================
Files 1477 1597 +120
Lines 438429 623940 +185511
=================================================
+ Hits 310015 343729 +33714
- Misses 108992 256366 +147374
- Partials 19422 23845 +4423
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/hold |
/unhold |
/ok-to-test |
/retest |
/type cherry-pick-for-release-8.0 |
/retest |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: ref #50701 close #51621
Problem Summary:
Currently eg.Go will generate too many goroutines if ingest too slow. then it will block goroutine release. eventually consume too many memory or even OOM.
What changed and how does it work?
This PR tried to give a high limitation of total download goroutines. which consider the balance of restore speed and memory usage.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.