Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix columns table query unstable #51896

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Conversation

ywqzzy
Copy link
Contributor

@ywqzzy ywqzzy commented Mar 19, 2024

What problem does this PR solve?

Issue Number: close #51829

Problem Summary:

What changed and how does it work?

Revert the change for V2

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
Copy link

tiprow bot commented Mar 19, 2024

Hi @ywqzzy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ywqzzy ywqzzy changed the title *:fix columns table query unstable *: fix columns table query unstable Mar 19, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #51896 (db39a95) into master (0d742d3) will decrease coverage by 17.6489%.
Report is 80 commits behind head on master.
The diff coverage is 90.9090%.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #51896         +/-   ##
=================================================
- Coverage   72.4732%   54.8243%   -17.6489%     
=================================================
  Files          1475       1588        +113     
  Lines        363671     620110     +256439     
=================================================
+ Hits         263564     339971      +76407     
- Misses        80719     256779     +176060     
- Partials      19388      23360       +3972     
Flag Coverage Δ
integration 36.6860% <90.9090%> (?)
unit 70.4732% <90.9090%> (-1.8905%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (-2.3014%) ⬇️
parser ∅ <ø> (∅)
br 49.6414% <ø> (+3.2320%) ⬆️

@Benjamin2037
Copy link
Collaborator

Please add test to cover the bug fix scenario.

Copy link
Collaborator

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
@ywqzzy
Copy link
Contributor Author

ywqzzy commented Mar 20, 2024

Please add test to cover the bug fix scenario.

No need to add tests since we just revert the code change. And lightning run the test daily.

Copy link

ti-chi-bot bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Benjamin2037,D3Hunter]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 20, 2024
Copy link

ti-chi-bot bot commented Mar 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-20 03:44:41.957612924 +0000 UTC m=+1434708.979859312: ☑️ agreed by Benjamin2037.
  • 2024-03-20 04:07:27.092466049 +0000 UTC m=+1436074.114712436: ☑️ agreed by D3Hunter.

Copy link

tiprow bot commented Mar 20, 2024

@ywqzzy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow db39a95 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit 968f4f2 into pingcap:master Mar 20, 2024
22 of 23 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #51960.

ti-chi-bot bot pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.0 release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select from information_schema.columns contains duplicate records
5 participants