Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: always rebuild plan for retry. #5219

Merged
merged 1 commit into from
Nov 25, 2017
Merged

Conversation

coocood
Copy link
Member

@coocood coocood commented Nov 25, 2017

Fixs record and index inconsistency bug.

Fixs record and index inconsistency bug.
@shenli
Copy link
Member

shenli commented Nov 25, 2017

/run-all-tests tidb-test=release-1.0

@@ -168,6 +168,7 @@ type ExecuteStmt struct {

Name string
UsingVars []ExprNode
ExecID uint32
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this ExecID be used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build Execute plan.

ctx context.Context
StmtNode ast.StmtNode

Ctx context.Context
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why export it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be constructed by another package.

@shenli
Copy link
Member

shenli commented Nov 25, 2017

LGTM

1 similar comment
@tiancaiamao
Copy link
Contributor

LGTM

@shenli shenli merged commit b8bcf9c into pingcap:release-1.0 Nov 25, 2017
@coocood coocood deleted the fix-retry branch November 25, 2017 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants