Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/parser: update OWNERS file #53314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented May 16, 2024

Keep the approvers of parser.go same with parser.y since the parser.go file is generated from parser.y file.

What problem does this PR solve?

Issue Number: ref #52933

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Keep the approvers of parser.go same with parser.y since the `parser.go` file is generated from `parser.y` file.
Copy link

ti-chi-bot bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bornchanger for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 16, 2024
Copy link

tiprow bot commented May 16, 2024

Hi @wuhuizuo. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wuhuizuo wuhuizuo changed the title chore(pkg/parser): update OWNERS file pkg/parser: update OWNERS file May 16, 2024
@wuhuizuo
Copy link
Contributor Author

/hold wait for approvals from the target approvers.
/cc @easonn7 @yudongusa

Copy link

ti-chi-bot bot commented May 16, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/hold wait for approvals from the target approvers.
/cc @easonn7 @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2024
@wuhuizuo
Copy link
Contributor Author

/cc @easonn7 @yudongusa

Copy link

ti-chi-bot bot commented May 16, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: easonn7, yudongusa.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @easonn7 @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant