-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: fix wrong result when convert float to unsigned (#53590) #53621
expression: fix wrong result when convert float to unsigned (#53590) #53621
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, wshwsh12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #53621 +/- ##
================================================
Coverage ? 73.6523%
================================================
Files ? 1096
Lines ? 351671
Branches ? 0
================================================
Hits ? 259014
Misses ? 76003
Partials ? 16654 |
This is an automated cherry-pick of #53590
What problem does this PR solve?
Issue Number: close #41736
Problem Summary:
int column
withnon int constant
, will convertnon int constant
to intAllowNegativeToUnsigned
is disabled.PS: what does
AllowNegativeToUnsigned
mean, check description hereWhat changed and how does it work?
Disable
AllowNegativeToUnsigned
when conversion happens when compareint column
withnon int constant
.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.