-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add some test cases for global index #53630
tests: add some test cases for global index #53630
Conversation
Hi @Defined2014. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #53630 +/- ##
================================================
+ Coverage 72.4359% 74.6958% +2.2599%
================================================
Files 1506 1506
Lines 430579 433795 +3216
================================================
+ Hits 311894 324027 +12133
+ Misses 99367 89796 -9571
- Partials 19318 19972 +654
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -375,40 +375,3 @@ func TestWithTiDBSnapshot(t *testing.T) { | |||
|
|||
tk.MustQuery("select * from xx").Check(testkit.Rows("1", "7")) | |||
} | |||
|
|||
func TestGlobalIndexPointGet(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move all global index related integration test to tests/integrationtest/t/globalindex
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjonss, xhebox, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #45133
Problem Summary:
tests/integrationtest/t/globalindex
expression_index
andaggregate
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.