Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add some test cases for global index #53630

Merged
merged 7 commits into from
May 29, 2024

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented May 28, 2024

What problem does this PR solve?

Issue Number: ref #45133

Problem Summary:

  1. Move all global index related integration test to tests/integrationtest/t/globalindex
  2. Add some tests related with expression_index and aggregate

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 28, 2024
Copy link

tiprow bot commented May 28, 2024

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Defined2014 Defined2014 changed the title tests: Add some test cases for global index tests: add some test cases for global index May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.6958%. Comparing base (bdb0545) to head (9b6a2b8).
Report is 14 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53630        +/-   ##
================================================
+ Coverage   72.4359%   74.6958%   +2.2599%     
================================================
  Files          1506       1506                
  Lines        430579     433795      +3216     
================================================
+ Hits         311894     324027     +12133     
+ Misses        99367      89796      -9571     
- Partials      19318      19972       +654     
Flag Coverage Δ
integration 49.2118% <ø> (?)
unit 71.5022% <ø> (+0.0900%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4776% <ø> (+9.0294%) ⬆️

@Defined2014
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented May 29, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -375,40 +375,3 @@ func TestWithTiDBSnapshot(t *testing.T) {

tk.MustQuery("select * from xx").Check(testkit.Rows("1", "7"))
}

func TestGlobalIndexPointGet(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all global index related integration test to tests/integrationtest/t/globalindex

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
@ti-chi-bot ti-chi-bot bot removed the approved label May 29, 2024
@Defined2014 Defined2014 requested a review from zimulala May 29, 2024 07:32
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 29, 2024
Copy link

ti-chi-bot bot commented May 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-29 06:53:34.029234495 +0000 UTC m=+2845767.786370067: ☑️ agreed by xhebox.
  • 2024-05-29 09:11:27.130240547 +0000 UTC m=+2854040.887376117: ☑️ agreed by mjonss.

Copy link

ti-chi-bot bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjonss, xhebox, zimulala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit c79716e into pingcap:master May 29, 2024
23 checks passed
@Defined2014 Defined2014 deleted the add-test-for-global-index branch May 29, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants