-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infoschema, http: add two HTTP API for keyvis #54608
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54608 +/- ##
=================================================
- Coverage 74.6219% 56.2128% -18.4092%
=================================================
Files 1551 1667 +116
Lines 362640 604791 +242151
=================================================
+ Hits 270609 339970 +69361
- Misses 72402 241591 +169189
- Partials 19629 23230 +3601
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -165,12 +165,34 @@ | |||
curl http://{TiDBIP}:10080/schema/{db} | |||
``` | |||
|
|||
```shell | |||
curl http://{TiDBIP}:10080/schema/{db}?id_name_only=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id_name_only=true
seems not RESTFUL...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/questions/39979533/how-should-rest-api-accept-boolean-values here suggested that use true
to represent boolean arguments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the design like schema/{db}?fields=id,name
, but it is OK for now since keyvis is the only user.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tangenta, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #54281
Problem Summary:
What changed and how does it work?
see tidb_http_api.md
Check List
Tests
cluster has a 488k tables' database
before & after
before (10s CPU profile)
after (10s CPU profile)
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.