Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoschema, http: add two HTTP API for keyvis #54608

Merged
merged 6 commits into from
Jul 16, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Jul 15, 2024

What problem does this PR solve?

Issue Number: close #54281

Problem Summary:

What changed and how does it work?

see tidb_http_api.md

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

cluster has a 488k tables' database

before & after

image

before (10s CPU profile)

img_v3_02cr_f3c3eeed-f276-44bf-9651-6cbd064e37cg

after (10s CPU profile)

image

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 15, 2024
Copy link

tiprow bot commented Jul 15, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 59.79381% with 39 lines in your changes missing coverage. Please review.

Project coverage is 56.2128%. Comparing base (2108661) to head (f39e3da).
Report is 1 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54608         +/-   ##
=================================================
- Coverage   74.6219%   56.2128%   -18.4092%     
=================================================
  Files          1551       1667        +116     
  Lines        362640     604791     +242151     
=================================================
+ Hits         270609     339970      +69361     
- Misses        72402     241591     +169189     
- Partials      19629      23230       +3601     
Flag Coverage Δ
integration 36.9452% <0.0000%> (?)
unit 71.6884% <59.7938%> (-1.8482%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.6043% <ø> (+4.9727%) ⬆️

Signed-off-by: lance6716 <lance6716@gmail.com>
@lance6716 lance6716 changed the title [WIP]infoschema, http: add two HTTP API for keyvis infoschema, http: add two HTTP API for keyvis Jul 15, 2024
@ti-chi-bot ti-chi-bot bot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-tests-checked labels Jul 15, 2024
@lance6716
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jul 15, 2024

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -165,12 +165,34 @@
curl http://{TiDBIP}:10080/schema/{db}
```

```shell
curl http://{TiDBIP}:10080/schema/{db}?id_name_only=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id_name_only=true seems not RESTFUL...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/39979533/how-should-rest-api-accept-boolean-values here suggested that use true to represent boolean arguments

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the design like schema/{db}?fields=id,name, but it is OK for now since keyvis is the only user.

Copy link

ti-chi-bot bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, tiancaiamao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
Copy link

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-15 09:01:53.30477972 +0000 UTC m=+258135.295721190: ☑️ agreed by tiancaiamao.
  • 2024-07-16 12:49:38.825717242 +0000 UTC m=+358200.816658714: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 9f1d9e6 into pingcap:master Jul 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When many tables under a DB, dashboard keyvis feature will cost a lot of resource
3 participants