session: bind extensions to bootstrap session

[yzhan1]

What problem does this PR solve?

Issue Number: close #54671

Problem Summary:

When bootstrapping with init SQL file, all extensions are not bind to the session object used for bootstrapping. This means if the init SQL file has any SQL statements which creates users using extension auth plugins, it will fail to execute because the executor can't find the plugin implementation.

What changed and how does it work?

This PR fixes it by properly binding all extensions to the session context used for bootstrapping.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)

  Repeat the steps in Cannot use extension auth plugin in init sql script #54671 and observe that the errors are gone and user is created

• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the issue where extension auth plugin used in init sql file will cause the file execution to fail

[ti-chi-bot]

Hi @yzhan1. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tiprow]

Hi @yzhan1. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yzhan1]

@lcwangchao @CbcWestwolf @bb7133 PTAL. Thanks!

[lance6716]

/ok-to-test

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.8992%. Comparing base (b5bbbf4) to head (aa05a7c).
Report is 45 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #54670         +/-   ##
=================================================
- Coverage   72.7196%   56.8992%   -15.8204%     
=================================================
  Files          1551       1681        +130     
  Lines        437087     621516     +184429     
=================================================
+ Hits         317848     353638      +35790     
- Misses        99645     244571     +144926     
- Partials      19594      23307       +3713     

Flag	Coverage Δ
integration	37.7234% <41.6666%> (?)
unit	72.2130% <50.0000%> (+0.4637%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9656% <ø> (ø)
parser	∅ <ø> (∅)
br	52.4403% <ø> (+6.6046%)	⬆️

[CbcWestwolf]

Please add a new UT to cover this scenario. You can take

tidb/pkg/session/test/session_test.go

Line 788 in ca7ba14

func TestInitUsers(t *testing.T) {

as a reference. :-)

[CbcWestwolf]

/retest

[lcwangchao]

/check-issue-triage-complete

[yzhan1]

@CbcWestwolf could you take a look again? Thanks!

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CbcWestwolf, lcwangchao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CbcWestwolf,lcwangchao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-07-22 06:28:51.98722918 +0000 UTC m=+853753.978170665: ☑️ agreed by lcwangchao.
• 2024-07-22 08:06:32.236259015 +0000 UTC m=+859614.227200486: ☑️ agreed by CbcWestwolf.

[yzhan1]

/retest

[yzhan1]

/test check-dev

[tiprow]

@yzhan1: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test fast_test_tiprow
• /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test check-dev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.