Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: support detaching the IndexReader and IndexLookUp #54800

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Issue Number: close #54799

Problem Summary:

Previously, the IndexReader and IndexLookUp didn't support lazy cursor fetch.

What changed and how does it work?

Now, the lazy cursor fetch function should also support IndexReader and IndexLookUp executors. It's implemented by adding Detach function on these executors.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Release note

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@YangKeao YangKeao requested a review from lcwangchao July 22, 2024 07:52
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 61.76471% with 13 lines in your changes missing coverage. Please review.

Project coverage is 56.5468%. Comparing base (07f7774) to head (dfdce6c).
Report is 18 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54800         +/-   ##
=================================================
- Coverage   74.7413%   56.5468%   -18.1945%     
=================================================
  Files          1555       1680        +125     
  Lines        363372     616521     +253149     
=================================================
+ Hits         271589     348623      +77034     
- Misses        72138     244443     +172305     
- Partials      19645      23455       +3810     
Flag Coverage Δ
integration 37.9514% <5.8823%> (?)
unit 72.3176% <61.7647%> (-1.3483%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (-2.2339%) ⬇️
parser ∅ <ø> (∅)
br 52.3800% <ø> (+4.7045%) ⬆️

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the detach-index-reader-lookup branch from f1156a9 to dfdce6c Compare July 22, 2024 08:33
@YangKeao YangKeao requested a review from xhebox July 23, 2024 03:32
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 23, 2024
Copy link

ti-chi-bot bot commented Jul 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-23 07:09:52.488911067 +0000 UTC m=+942614.479852537: ☑️ agreed by lcwangchao.
  • 2024-07-23 09:10:20.480317914 +0000 UTC m=+949842.471259381: ☑️ agreed by xhebox.

@hawkingrei
Copy link
Member

/retest

@ti-chi-bot ti-chi-bot bot merged commit be01e5a into pingcap:master Jul 23, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support detaching the IndexReader and IndexLookUp executor
4 participants