pkg/parser: use clearer structures for RESOURCE GROUP ASTs #54881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #54881 +/- ##
=================================================
- Coverage 72.9336% 56.0708% -16.8628%
=================================================
Files 1558 1680 +122
Lines 438456 614078 +175622
=================================================
+ Hits 319782 344319 +24537
- Misses 99064 246446 +147382
- Partials 19610 23313 +3703
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: JmPotato <ghzpotato@gmail.com>
Signed-off-by: JmPotato <ghzpotato@gmail.com>
JmPotato
force-pushed
the
refine_runaway_ast
branch
from
f3fdd2a to
60d884d
Compare
ti-chi-bot
bot
removed
the
needs-rebase
tangenta
approved these changes
Jul 25, 2024
|
/approve |
Signed-off-by: JmPotato <ghzpotato@gmail.com>
D3Hunter
approved these changes
Jul 25, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, easonn7, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #54434.
What changed and how does it work?
Before this PR, many
RESOURCE GROUPandQUERY WATCHASTs used ambiguous union struct fields to parse different options. This PR makes them use clearer structures to improve readability and extensibility.Check List
Tests
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.