Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] *: Support Vector Data Type and Functions #54901

Closed
wants to merge 7 commits into from

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jul 25, 2024

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

This is the feature branch PR for adding vector data type into TiDB, consists of several independently-reviewed commits.

Vector index is not introduced in this PR.

Because downstream tools do not support vector data type yet, the Vector data type must be explicitly enabled via a GLOBAL variable. This allows other tools to work with this data type and provide compatibilities.

Related:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

*: Support Vector Data Type

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 25, 2024
@breezewish breezewish changed the title *: Support Vector Data Type [DNM] *: Support Vector Data Type Jul 25, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2024
@breezewish breezewish changed the title [DNM] *: Support Vector Data Type [DNM] *: Support Vector Data Type and Functions Jul 25, 2024
@breezewish breezewish closed this Jul 25, 2024
@breezewish breezewish force-pushed the feature/vector-search/vector-data-type branch from 35d053a to 1acb8f7 Compare July 25, 2024 07:27
@breezewish breezewish reopened this Aug 2, 2024
@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 2, 2024
Copy link

ti-chi-bot bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ailinkid, tangenta, xuhuaiyu for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pingcap pingcap deleted a comment from ti-chi-bot bot Aug 2, 2024
@pingcap pingcap deleted a comment from codecov bot Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.6942%. Comparing base (1acb8f7) to head (35d053a).
Report is 227 commits behind head on master.

Current head 35d053a differs from pull request most recent head c4a1f18

Please upload reports for the commit c4a1f18 to get more accurate results.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #54901         +/-   ##
=================================================
- Coverage   72.8511%   55.6942%   -17.1570%     
=================================================
  Files          1558       1680        +122     
  Lines        438406     610512     +172106     
=================================================
+ Hits         319384     340020      +20636     
- Misses        99322     247074     +147752     
- Partials      19700      23418       +3718     
Flag Coverage Δ
integration 23.1741% <ø> (?)
unit 71.7961% <ø> (-0.0622%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5905% <ø> (+6.7162%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2024
Copy link

tiprow bot commented Aug 20, 2024

@breezewish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow c4a1f18 link true /test fast_test_tiprow
tidb_parser_test c4a1f18 link true /test tidb_parser_test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Aug 20, 2024

@breezewish: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test c4a1f18 link true /test unit-test
pull-mysql-client-test c4a1f18 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/mysql-test c4a1f18 link true /test mysql-test
idc-jenkins-ci-tidb/check_dev c4a1f18 link true /test check-dev
pull-integration-ddl-test c4a1f18 link true /test pull-integration-ddl-test
pull-br-integration-test c4a1f18 link true /test pull-br-integration-test
idc-jenkins-ci-tidb/check_dev_2 c4a1f18 link true /test check-dev2
idc-jenkins-ci-tidb/build c4a1f18 link true /test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@breezewish
Copy link
Member Author

breezewish commented Aug 21, 2024

Close for #55550

@breezewish breezewish closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants