Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: decouple job scheduler from 'ddl' and make it run/exit as owner changes (#53548) #55067

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53548

What problem does this PR solve?

Issue Number: ref #53246

Problem Summary:

What changed and how does it work?

  • decouple ddl job scheduler part out of ddl partially, some fields are still coupled, and make it a separate and cancellable module. it should make further test easier.
    • all context usage now changed to scheduler/worker context which is only valid during being owner from ddl context
    • current ddl context is non-cancellable, which might cause some issue when owner change, as it cannot be cancelled in time, it might keeps running until we hopefully met some isOwner check, so the duration of co-exist of 2 owner might be quite long.
  • after this pr, job scheduler related routine will only be start when current node is elected as owner. start SyncJobSchemaVerLoop only on owner node.
  • fix add-index disttask scheduler uses the 'ddlCtx.ctx', it should use the context we pass in.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • tiup a cluster with 3 tidb
    • run a script to create 1000 tables with 10 threads, during this time we keeps delete keys of prefix /tidb/ddl/fg/owner/, to force owner change
    • ddl should be run success, and no abnormal output in logs.
mysql> select count(1) from INFORMATION_SCHEMA.tables where table_schema='ff_0';
+----------+
| count(1) |
+----------+
|     1000 |
+----------+
1 row in set (0.01 sec)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Jul 30, 2024
Copy link

ti-chi-bot bot commented Jul 30, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133, tangenta for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter D3Hunter closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants