Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: clone table for show columns #55309

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

GMHDBJD
Copy link
Contributor

@GMHDBJD GMHDBJD commented Aug 8, 2024

What problem does this PR solve?

Issue Number: close #55301

Problem Summary:

What changed and how does it work?

  • clone table before fill column types

Check List

Tests

Running tool: /usr/local/go/bin/go test -timeout 10m -coverprofile=/tmp/vscode-gomVYcKs/go-code-cover -run ^TestShowViewPriv$ github.com/pingcap/tidb/pkg/privilege/privileges -race --tags=intest

ok  	github.com/pingcap/tidb/pkg/privilege/privileges	12.034s	coverage: 27.4% of statements
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2024
Copy link

tiprow bot commented Aug 8, 2024

Hi @GMHDBJD. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 8, 2024
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.8015%. Comparing base (d0c1ca1) to head (739e30c).
Report is 13 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #55309        +/-   ##
================================================
+ Coverage   72.8488%   74.8015%   +1.9526%     
================================================
  Files          1570       1570                
  Lines        439488     441479      +1991     
================================================
+ Hits         320162     330233     +10071     
+ Misses        99607      90993      -8614     
- Partials      19719      20253       +534     
Flag Coverage Δ
integration 49.1724% <25.0000%> (?)
unit 71.7976% <25.0000%> (-0.0802%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5154% <ø> (+6.6366%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 8, 2024
@GMHDBJD
Copy link
Contributor Author

GMHDBJD commented Aug 8, 2024

/retest

Copy link

tiprow bot commented Aug 8, 2024

@GMHDBJD: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Aug 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lance6716,wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 9, 2024
Copy link

ti-chi-bot bot commented Aug 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-08 10:20:09.187017357 +0000 UTC m=+520139.054116444: ☑️ agreed by lance6716.
  • 2024-08-09 06:28:35.712996047 +0000 UTC m=+592645.580095135: ☑️ agreed by wjhuang2016.

@ti-chi-bot ti-chi-bot bot merged commit 29122de into pingcap:master Aug 9, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ddl: show columns should not change the memory table info
3 participants