-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add ctx parameter to infoschema TableByID #55329
Conversation
Signed-off-by: lance6716 <lance6716@gmail.com>
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: easonn7, hawkingrei, Leavrth, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55329 +/- ##
================================================
+ Coverage 72.8172% 75.3543% +2.5371%
================================================
Files 1570 1570
Lines 439591 440743 +1152
================================================
+ Hits 320098 332119 +12021
+ Misses 99757 88069 -11688
- Partials 19736 20555 +819
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@lance6716: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: lance6716 <lance6716@gmail.com>
What problem does this PR solve?
Issue Number: ref #50959
Problem Summary:
What changed and how does it work?
In infoschema v1, all schema meta are in-memory, so TableByName are fast enough.
In infoschema v2, there may be cache miss and loading from remote network, that could be slower.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.