-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: support session level tidb_ddl_reorg_worker_cnt and batch_size #55334
Conversation
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55334 +/- ##
================================================
+ Coverage 72.9400% 75.2401% +2.3001%
================================================
Files 1570 1580 +10
Lines 439546 455968 +16422
================================================
+ Hits 320605 343071 +22466
+ Misses 99276 92037 -7239
- Partials 19665 20860 +1195
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
2ea8a58
to
9e95940
Compare
/retest |
@tangenta: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/approve |
1 similar comment
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, easonn7, lance6716, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What problem does this PR solve?
Issue Number: close #55335
Problem Summary: see #55335
What changed and how does it work?
tidb_ddl_reorg_worker_cnt
andtidb_ddl_reorg_batch_size
.Check List
Tests
Execute following SQLs on root user:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.