Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: Fix more cases that explain does not display a truncated value #55466

Closed
wants to merge 8 commits into from

Conversation

EricZequan
Copy link
Contributor

@EricZequan EricZequan commented Aug 16, 2024

What problem does this PR solve?

Issue Number: ref #54245

Problem Summary:

What changed and how does it work?

This PR brings long constant truncation to more kind of plans.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. labels Aug 16, 2024
@EricZequan EricZequan marked this pull request as draft August 16, 2024 08:06
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
Copy link

tiprow bot commented Aug 16, 2024

Hi @EricZequan. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan EricZequan marked this pull request as ready for review August 16, 2024 08:07
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2024
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.0721%. Comparing base (5dae1a3) to head (8d2e4b1).
Report is 215 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55466         +/-   ##
=================================================
- Coverage   72.8045%   56.0721%   -16.7324%     
=================================================
  Files          1604       1729        +125     
  Lines        445563     622236     +176673     
=================================================
+ Hits         324390     348901      +24511     
- Misses       101206     249587     +148381     
- Partials      19967      23748       +3781     
Flag Coverage Δ
integration 37.2679% <87.0967%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8979% <ø> (+7.0977%) ⬆️

@ti-chi-bot ti-chi-bot bot added sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2024
@EricZequan EricZequan marked this pull request as draft August 19, 2024 01:26
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 19, 2024
@EricZequan EricZequan marked this pull request as ready for review August 19, 2024 04:05
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2024
@EricZequan EricZequan marked this pull request as draft August 19, 2024 15:30
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2024
@EricZequan EricZequan marked this pull request as ready for review August 23, 2024 03:36
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 23, 2024
@EricZequan
Copy link
Contributor Author

/retest

1 similar comment
@EricZequan
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Aug 29, 2024

@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EricZequan EricZequan force-pushed the display-truncate-value branch from ba5e6ed to 6c12422 Compare September 4, 2024 10:19
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan EricZequan force-pushed the display-truncate-value branch from 6c12422 to 41ace51 Compare September 4, 2024 14:24
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 4, 2024
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@EricZequan EricZequan force-pushed the display-truncate-value branch from e2602c6 to 6b22b5f Compare September 6, 2024 02:50
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 6, 2024
@EricZequan EricZequan force-pushed the display-truncate-value branch from f2699ea to 0102a0f Compare September 6, 2024 03:50
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
Signed-off-by: “EricZequan” <zequany33@gmail.com>
Signed-off-by: “EricZequan” <zequany33@gmail.com>
Signed-off-by: “EricZequan” <zequany33@gmail.com>
@EricZequan EricZequan force-pushed the display-truncate-value branch from 93aa71c to 0958e52 Compare September 6, 2024 08:05
@EricZequan
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 6, 2024

@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: “EricZequan” <zequany33@gmail.com>
Copy link

ti-chi-bot bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xuhuaiyu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: “EricZequan” <zequany33@gmail.com>
Copy link

ti-chi-bot bot commented Sep 9, 2024

@EricZequan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 8d2e4b1 link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Sep 29, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 29, 2024
@breezewish
Copy link
Member

Close for #55934

@breezewish breezewish closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants