-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: Fix more cases that explain does not display a truncated value #55466
Conversation
Hi @EricZequan. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #55466 +/- ##
=================================================
- Coverage 72.8045% 56.0721% -16.7324%
=================================================
Files 1604 1729 +125
Lines 445563 622236 +176673
=================================================
+ Hits 324390 348901 +24511
- Misses 101206 249587 +148381
- Partials 19967 23748 +3781
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
1 similar comment
/retest |
@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ba5e6ed
to
6c12422
Compare
Signed-off-by: “EricZequan” <zequany33@gmail.com>
6c12422
to
41ace51
Compare
Signed-off-by: “EricZequan” <zequany33@gmail.com>
e2602c6
to
6b22b5f
Compare
f2699ea
to
0102a0f
Compare
Signed-off-by: “EricZequan” <zequany33@gmail.com>
93aa71c
to
0958e52
Compare
/retest |
@EricZequan: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: “EricZequan” <zequany33@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@EricZequan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Close for #55934 |
What problem does this PR solve?
Issue Number: ref #54245
Problem Summary:
What changed and how does it work?
This PR brings long constant truncation to more kind of plans.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.