Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makefile: update dumpling build options (#41165) #55554

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #41165

What problem does this PR solve?

Issue Number: close #55349

Problem Summary:

What is changed and how it works?

after upgrade a dependency in #41111, macOS must turn on cgo to build

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
manually make build_dumpling on macOS

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 21, 2024
@wuhuizuo
Copy link
Contributor

wuhuizuo commented Aug 21, 2024

/cc @lance6716 @D3Hunter

failure happened in release-6.1 building on fail-point profile

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 21, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 21, 2024
Copy link

ti-chi-bot bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 21, 2024
Copy link

ti-chi-bot bot commented Aug 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-21 07:02:06.454883969 +0000 UTC m=+335321.589334091: ☑️ agreed by lance6716.
  • 2024-08-21 07:08:25.721282043 +0000 UTC m=+335700.855732164: ☑️ agreed by D3Hunter.

@ti-chi-bot ti-chi-bot bot merged commit 8253658 into pingcap:release-6.1 Aug 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants