*: fix data race in the EnableAnalyzeSnapshot #55596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #55596 +/- ##
================================================
+ Coverage 72.8853% 74.9137% +2.0284%
================================================
Files 1580 1580
Lines 442642 443283 +641
================================================
+ Hits 322621 332080 +9459
+ Misses 100187 90968 -9219
- Partials 19834 20235 +401
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
winoros
approved these changes
Aug 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
1 similar comment
|
/retest |
ti-chi-bot
bot
added
needs-cherry-pick-release-7.5
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Aug 29, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tidb
that referenced
this pull request
Aug 29, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
13 tasks
hawkingrei
added a commit
to ti-chi-bot/tidb
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
hawkingrei
added a commit
to ti-chi-bot/tidb
that referenced
this pull request
Sep 23, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #55469
Problem Summary:
What changed and how does it work?
EnableAnalyzeSnapshotshould not be used with different goroutines.Check List
Tests
enable race for analyze test.
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.