Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: improve priority of suppressErrorTooLongKeyKey for DM (#55164) #55772

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55164

What problem does this PR solve?

Issue Number: close #55138

Problem Summary:

seems suppressErrorTooLongKeyKey is only used by DM, so increase its priority

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Aug 30, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 30, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 30, 2024
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2024
@fzzf678
Copy link
Contributor

fzzf678 commented Aug 30, 2024

/lgtm

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 30, 2024
Copy link

ti-chi-bot bot commented Aug 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-30 09:44:19.141901532 +0000 UTC m=+5583.659954450: ☑️ agreed by lance6716.
  • 2024-08-30 09:48:49.660533027 +0000 UTC m=+5854.178585953: ☑️ agreed by fzzf678.

Signed-off-by: lance6716 <lance6716@gmail.com>
Copy link

ti-chi-bot bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lance6716
Copy link
Contributor

/retest

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-6.5@2253874). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #55772   +/-   ##
================================================
  Coverage               ?   73.6160%           
================================================
  Files                  ?       1097           
  Lines                  ?     352476           
  Branches               ?          0           
================================================
  Hits                   ?     259479           
  Misses                 ?      76301           
  Partials               ?      16696           

@ti-chi-bot ti-chi-bot bot merged commit 1211fb2 into pingcap:release-6.5 Aug 30, 2024
10 checks passed
@lance6716
Copy link
Contributor

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member Author

@lance6716: new pull request created to branch release-7.1: #57108.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot added a commit to ti-chi-bot/tidb that referenced this pull request Nov 4, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants