*: support for adding/dropping vector index | tidb-test=723d2370f1b3956d22a5ab87b1fc8b9b864ca051

[zimulala]

What problem does this PR solve?

Issue Number: close #55840

Problem Summary:

• Support for adding/dropping vector index after table creation in the DDL
  • support rollback
  • support sending a request to synchronize schema
    • don't support handling errors when check process.
• Support for Compatible with Related Admin Functions
  • admin cancel
  • admin check table/index
  • admin cleanup index

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[tiprow]

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 67.61269% with 194 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/vector-index@ee3a596). Learn more about missing BASE report.

Additional details and impacted files

@@                    Coverage Diff                    @@
##             feature/vector-index     #55839   +/-   ##
=========================================================
  Coverage                        ?   57.2832%           
=========================================================
  Files                           ?       1761           
  Lines                           ?     651421           
  Branches                        ?          0           
=========================================================
  Hits                            ?     373155           
  Misses                          ?     252934           
  Partials                        ?      25332           

Flag	Coverage Δ
integration	39.4530% <24.9122%> (?)
unit	72.0139% <65.4941%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9567% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	62.9298% <0.0000%> (?)

[tangenta]

We are trying to define a struct for each type of DDL jobs (see job_args.go in #55854), this will be removed, FYI

[D3Hunter]

yes, please merge master, use job version 2

[zimulala]

Currently merge master results in a lot of commits and code changes that are not part of this PR. I will merge master after this PR.

This "drop index" type is just adding an arg, I will not change this PR for the time being, if you change it then, I will synchronously change it.

[wjhuang2016]

Please use a separate logic to handle it. And the name 'reorg' is not suitable for it. We don't want to consider the vector index during refactoring index.

[zimulala]

Done.

[zimulala]

/retest-required

[tiprow]

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[AilinKid]

For planner part rest LGTM

[tangenta]

Rest LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-09-14 07:44:54.507670441 +0000 UTC m=+687964.248094379: ☑️ agreed by wjhuang2016.
• 2024-09-14 09:37:39.914980041 +0000 UTC m=+694729.655403965: ☑️ agreed by tangenta.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [AilinKid,tangenta,wjhuang2016]
• pkg/ddl/OWNERS [tangenta,wjhuang2016]
• pkg/domain/OWNERS [tangenta,wjhuang2016]
• pkg/infoschema/OWNERS [tangenta,wjhuang2016]
• pkg/meta/OWNERS [tangenta,wjhuang2016]
• pkg/parser/OWNERS [tangenta]
• pkg/planner/OWNERS [AilinKid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment