Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: move index advisor into the kernel #55874

Merged
merged 7 commits into from
Sep 5, 2024
Merged

planner: move index advisor into the kernel #55874

merged 7 commits into from
Sep 5, 2024

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Sep 5, 2024

What problem does this PR solve?

Issue Number: ref #12303

Problem Summary: planner: move index advisor into the kernel

What changed and how does it work?

planner: move index advisor into the kernel

  1. move the algorithm code into TiDB.
  2. add more test cases

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 5, 2024
@tiprow tiprow
Copy link

tiprow bot commented Sep 5, 2024

Hi @qw4990. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 64.47140% with 205 lines in your changes missing coverage. Please review.

Project coverage is 56.1665%. Comparing base (edbec22) to head (0fef51a).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@                Coverage Diff                @@
##             master     #55874         +/-   ##
=================================================
- Coverage   72.8524%   56.1665%   -16.6860%     
=================================================
  Files          1598       1726        +128     
  Lines        444534     623364     +178830     
=================================================
+ Hits         323854     350122      +26268     
- Misses       100754     249553     +148799     
- Partials      19926      23689       +3763
Flag Coverage Δ
integration 37.3996% <0.0000%> (?)
unit 72.0822% <64.4714%> (+0.1199%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (ø)
parser ∅ <ø> (∅)
br 52.8946% <ø> (+7.1179%) ⬆️

hawkingrei
hawkingrei reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@hawkingrei hawkingrei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other, LGTM

qw4990 and others added 2 commits September 5, 2024 17:22
@qw4990 @hawkingrei
Update pkg/planner/indexadvisor/algorithm.go
7bdc5ee 
Co-authored-by: Weizhen Wang <wangweizhen@pingcap.com>
@qw4990
fixup
0fef51a
@qw4990
Copy link
Contributor Author

qw4990 commented Sep 5, 2024

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Sep 5, 2024

@qw4990: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

elsa0520
elsa0520 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elsa0520, hawkingrei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-05 10:21:29.802735677 +0000 UTC m=+526214.320788600: ☑️ agreed by elsa0520.
  • 2024-09-05 12:21:49.684048545 +0000 UTC m=+533434.202101470: ☑️ agreed by hawkingrei.

@tiprow tiprow
Copy link

tiprow bot commented Sep 5, 2024

@qw4990: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow 0fef51a link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot merged commit e9124dd into pingcap:master Sep 5, 2024
22 of 23 checks passed
breezewish added a commit to breezewish/tidb that referenced this pull request Sep 8, 2024
@breezewish
Merge remote-tracking branch 'origin/master' into wenxuan/truncate-vecs
87c4984 
* origin/master: (33 commits)
  build(deps): bump github.com/prometheus/common from 0.55.0 to 0.57.0 (pingcap#55762)
  build(deps): bump golang.org/x/sys from 0.24.0 to 0.25.0 (pingcap#55894)
  planner: fix incorrect estRows with global index and json column (pingcap#55842)
  ddl, stat: switch to new struct for add/truncate/drop partition (pingcap#55893)
  planner: hide instance plan cache eviction log if no plan is evicted (pingcap#55918)
  expression: support tidb encode key function (pingcap#51678)
  planner: fix incorrect maintenance of `handleColHelper` for recursive CTE (pingcap#55732)
  executor: some code refine of hash join v2 (pingcap#55887)
  infoschema, meta: fix wrong auto id after `rename table` (pingcap#55847)
  ddl/ingest: set `minCommitTS` when detect remote duplicate keys (pingcap#55588)
  planner: move index advisor into the kernel (pingcap#55874)
  ddl, stats: switch to new struct for create/truncate table (pingcap#55811)
  executor: avoid new small objects in probe stage of hash join v2 (pingcap#55855)
  *: Add tidbCPU/tikvCPU into system tables (pingcap#55455)
  ddl: use static contexts in `NewReorgCopContext` (pingcap#55823)
  executor: fix index out of range bug in hash join v2 (pingcap#55864)
  executor: record index usage for the clustered primary keys (pingcap#55602)
  domain: load all non-public tables into infoschema (pingcap#55142)
  test: fix unstable TestShowViewPriv (pingcap#55868)
  ttl: add `varbinary` case for `TestSplitTTLScanRangesWithBytes` (pingcap#55863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsa0520 elsa0520 elsa0520 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @hawkingrei @elsa0520