Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Drop partition DDL handling for overlapping partitions during State Changes | tidb-test=pr/2402 #56082

Merged
merged 40 commits into from
Oct 9, 2024

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Sep 13, 2024

What problem does this PR solve?

Issue Number: close #55888

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Copy link

ti-chi-bot bot commented Sep 13, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/needs-triage-completed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/planner SIG: Planner labels Sep 13, 2024
Copy link

tiprow bot commented Sep 13, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjonss
Copy link
Contributor Author

mjonss commented Sep 13, 2024

/test all

Copy link

tiprow bot commented Sep 13, 2024

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 81.45161% with 46 lines in your changes missing coverage. Please review.

Project coverage is 76.0586%. Comparing base (1eb0c8c) to head (6ecceb5).
Report is 458 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56082        +/-   ##
================================================
+ Coverage   73.3698%   76.0586%   +2.6887%     
================================================
  Files          1626       1652        +26     
  Lines        448852     458052      +9200     
================================================
+ Hits         329322     348388     +19066     
+ Misses        99364      87991     -11373     
- Partials      20166      21673      +1507     
Flag Coverage Δ
integration 51.8444% <47.1774%> (?)
unit 72.4826% <80.2419%> (+0.0194%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0343% <ø> (+17.4573%) ⬆️

@mjonss mjonss marked this pull request as ready for review September 15, 2024 20:36
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2024
@D3Hunter
Copy link
Contributor

D3Hunter commented Oct 8, 2024

/approve

@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

@Benjamin2037
Copy link
Collaborator

/approve

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Benjamin2037, D3Hunter, Defined2014, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 9, 2024
@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

2 similar comments
@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

2 similar comments
@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

@mjonss
Copy link
Contributor Author

mjonss commented Oct 9, 2024

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1e24d39 into pingcap:master Oct 9, 2024
25 checks passed
@mjonss mjonss deleted the drop-partition-no-global-index branch October 10, 2024 13:02
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Oct 28, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-7.1 from head ti-chi-bot:cherry-pick-56082-to-release-7.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID ACA6:3F108B:1B758AA:33BDA20:671F4642 and timestamp 2024-10-28 08:07:30 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits","status":"403"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Oct 28, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 6, 2024
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 10, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 10, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #58121.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request could not be created: failed to create pull request against pingcap/tidb#release-8.1 from head ti-chi-bot:cherry-pick-56082-to-release-8.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID EABA:1249B6:273F1A1:4D7BAC2:67592478 and timestamp 2024-12-11 05:34:49 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits","status":"403"}

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Dec 11, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DROP PARTITION has an anomaly during DELETE ONLY state, which looks like PK violation.
7 participants