Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: let cast function supports explicit set charset (#55724) #56088

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #55724

What problem does this PR solve?

Issue Number: close #55677

Problem Summary: Ref https://dev.mysql.com/doc/refman/8.4/en/cast-functions.html#cast-function-descriptions

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2024
@ti-chi-bot ti-chi-bot force-pushed the cherry-pick-55724-to-release-7.5 branch from 7ac56b5 to 7f75836 Compare September 14, 2024 06:30
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cherry-pick-approved Cherry pick PR approved by release team. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/cherry-pick-not-approved labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 84.44444% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-7.5@cdd7546). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.5     #56088   +/-   ##
================================================
  Coverage               ?   72.0121%           
================================================
  Files                  ?       1413           
  Lines                  ?     411947           
  Branches               ?          0           
================================================
  Hits                   ?     296652           
  Misses                 ?      95405           
  Partials               ?      19890           
Flag Coverage Δ
unit 72.0121% <84.4444%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9400% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 53.5154% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
Copy link

ti-chi-bot bot commented Sep 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 04:47:19.482441173 +0000 UTC m=+1454909.222865107: ☑️ agreed by Defined2014.
  • 2024-09-23 05:52:45.835152326 +0000 UTC m=+1458835.575576265: ☑️ agreed by XuHuaiyu.

@Defined2014
Copy link
Contributor

/retest

@Defined2014 Defined2014 force-pushed the cherry-pick-55724-to-release-7.5 branch from 84f2300 to 9d4d44a Compare September 23, 2024 06:27
@ti-chi-bot ti-chi-bot bot merged commit e98c739 into pingcap:release-7.5 Sep 23, 2024
17 of 18 checks passed
@Defined2014 Defined2014 deleted the cherry-pick-55724-to-release-7.5 branch September 23, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants