Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support create table with vector indexes and others | tidb-test=c567cde7e19a55a67960a404906cb859ca44f206 #56124

Merged

Conversation

zimulala
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #56122

Problem Summary:

  • Support for adding/dropping vector index during table creation in the DDL
    • If the table hasn't TiFlash replica, default set it count to 1.
  • Unsupported operations:
    • admin cleanup index
    • set the vector index to invisible

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2024
Copy link

tiprow bot commented Sep 18, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala zimulala force-pushed the zimuxia/create-table-others branch from 12b1333 to 1f61d27 Compare September 19, 2024 01:27
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 76.76768% with 23 lines in your changes missing coverage. Please review.

Please upload report for BASE (feature/vector-index@384d4ed). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             feature/vector-index     #56124   +/-   ##
=========================================================
  Coverage                        ?   75.2750%           
=========================================================
  Files                           ?       1633           
  Lines                           ?     476822           
  Branches                        ?          0           
=========================================================
  Hits                            ?     358928           
  Misses                          ?      95802           
  Partials                        ?      22092           
Flag Coverage Δ
integration 52.1098% <24.2424%> (?)
unit 71.9927% <76.7676%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 62.9357% <0.0000%> (?)

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 19, 2024
@zimulala zimulala force-pushed the zimuxia/create-table-others branch from 1f61d27 to 0d7ff37 Compare September 19, 2024 02:33
@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 19, 2024
@zimulala zimulala changed the title *: support create table with vector indexes and others *: support create table with vector indexes and others | tidb-test=pr/2393 Sep 19, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 19, 2024
@zimulala zimulala changed the title *: support create table with vector indexes and others | tidb-test=pr/2393 *: support create table with vector indexes and others | tidb-test=cdef381f06709291578d2bdbe2db8c2c2c390c34 Sep 19, 2024
@zimulala
Copy link
Contributor Author

/retest

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 19, 2024
Copy link

tiprow bot commented Sep 19, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap pingcap deleted a comment from tiprow bot Sep 19, 2024
@zimulala zimulala changed the title *: support create table with vector indexes and others | tidb-test=cdef381f06709291578d2bdbe2db8c2c2c390c34 *: support create table with vector indexes and others | tidb-test=876924928b2debc97cdacb785fdee6809513f808 Sep 19, 2024
@zimulala
Copy link
Contributor Author

/retest

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 19, 2024
Copy link

tiprow bot commented Sep 19, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@purelind
Copy link
Contributor

/test mysql-test

Copy link

tiprow bot commented Sep 19, 2024

@purelind: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala zimulala force-pushed the zimuxia/create-table-others branch from cbbb596 to a8ed25a Compare September 20, 2024 09:29
@ti-chi-bot ti-chi-bot bot added the sig/planner SIG: Planner label Sep 20, 2024
@zimulala zimulala force-pushed the zimuxia/create-table-others branch from a8ed25a to 0848f53 Compare September 20, 2024 10:02
@zimulala zimulala changed the title *: support create table with vector indexes and others | tidb-test=876924928b2debc97cdacb785fdee6809513f808 *: support create table with vector indexes and others | tidb-test=35dbd99cd89500ec78cf765a638c8f21ce012fcd Sep 20, 2024
@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 20, 2024
@zimulala zimulala changed the title *: support create table with vector indexes and others | tidb-test=35dbd99cd89500ec78cf765a638c8f21ce012fcd *: support create table with vector indexes and others | tidb-test=06eb90421605c6f23c8065a6b99d248d4006b4ab Sep 20, 2024
@zimulala
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 24, 2024
pkg/ddl/column.go Outdated Show resolved Hide resolved
pkg/ddl/index.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@zimulala zimulala changed the title *: support create table with vector indexes and others | tidb-test=06eb90421605c6f23c8065a6b99d248d4006b4ab *: support create table with vector indexes and others | tidb-test=c567cde7e19a55a67960a404906cb859ca44f206 Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@zimulala
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Sep 25, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Sep 25, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pingcap pingcap deleted a comment from ti-chi-bot bot Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 25, 2024
Copy link

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 04:04:59.65607355 +0000 UTC m=+1625169.396497485: ☑️ agreed by tangenta.
  • 2024-09-25 12:54:47.507709544 +0000 UTC m=+1656957.248133484: ☑️ agreed by wjhuang2016.

@zimulala
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Sep 26, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zimulala
Copy link
Contributor Author

/retest-required

Copy link

tiprow bot commented Sep 26, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, tangenta, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit f23ad9f into pingcap:feature/vector-index Sep 26, 2024
22 checks passed
@zimulala zimulala deleted the zimuxia/create-table-others branch September 26, 2024 08:40
@zimulala zimulala mentioned this pull request Sep 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants