Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refactor V2 args for RebaseAutoID/Modify-table/Index-visibility/FK related DDL. #56164

Merged
merged 19 commits into from
Sep 24, 2024

Conversation

joccau
Copy link
Member

@joccau joccau commented Sep 19, 2024

What problem does this PR solve?

Issue Number: Ref #53930
Ref #54436

Problem Summary:
The ddl types that this pr refactor:

  • RebaseAutoID
  • RebaseAutoRandomBase
  • ModifyTableComment
  • ModifyTableCharsetAndCollate
  • AlterIndexVisibility
  • AddForeignKey
  • DropForeignKey

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked do-not-merge/needs-linked-issue labels Sep 19, 2024
…se ddl

Signed-off-by: joccau <zak.zhao@pingcap.cn>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 85.20710% with 25 lines in your changes missing coverage. Please review.

Project coverage is 76.3064%. Comparing base (9785cdd) to head (69f9ce2).
Report is 6 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56164        +/-   ##
================================================
+ Coverage   73.4371%   76.3064%   +2.8693%     
================================================
  Files          1600       1623        +23     
  Lines        443777     453815     +10038     
================================================
+ Hits         325897     346290     +20393     
+ Misses        97932      86185     -11747     
- Partials      19948      21340      +1392     
Flag Coverage Δ
integration 52.5399% <73.3727%> (?)
unit 72.7605% <85.2071%> (+0.2582%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.2738% <ø> (+17.3977%) ⬆️

Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau force-pushed the rebase-auto-ID-args branch from 82b25a1 to 9602c87 Compare September 19, 2024 11:40
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@joccau joccau changed the title [WIP]ddl: refactor V2 args for ActionRebaseAutoID, ActionRebaseAutoRandomBase ddl. [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment DDL. Sep 19, 2024
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau changed the title [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment DDL. [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment/ModifyTableCharsetAndCollate DDL. Sep 19, 2024
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau force-pushed the rebase-auto-ID-args branch from f6972f4 to 6171a43 Compare September 19, 2024 12:12
@joccau joccau changed the title [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment/ModifyTableCharsetAndCollate DDL. [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment/ModifyTableCharsetAndCollate/AlterIndexVisibility DDL. Sep 19, 2024
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 20, 2024
@joccau joccau changed the title [WIP]ddl: refactor V2 args for RebaseAutoID/RebaseAutoRandomBase/ModifyTableComment/ModifyTableCharsetAndCollate/AlterIndexVisibility DDL. [WIP]ddl: refactor V2 args for DDL. Sep 20, 2024
@joccau joccau force-pushed the rebase-auto-ID-args branch from 6ceb370 to b045bd5 Compare September 20, 2024 07:32
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau force-pushed the rebase-auto-ID-args branch from b045bd5 to b6d5981 Compare September 20, 2024 08:00
@joccau joccau changed the title [WIP]ddl: refactor V2 args for DDL. ddl: refactor V2 args for DDL. Sep 20, 2024
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args.go Outdated Show resolved Hide resolved
pkg/ddl/foreign_key_test.go Outdated Show resolved Hide resolved
pkg/meta/model/job.go Outdated Show resolved Hide resolved
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau requested a review from D3Hunter September 23, 2024 03:42
pkg/ddl/multi_schema_change.go Outdated Show resolved Hide resolved
pkg/meta/model/job_args_test.go Outdated Show resolved Hide resolved
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@joccau joccau requested a review from D3Hunter September 23, 2024 06:25
Signed-off-by: joccau <zak.zhao@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 23, 2024
@joccau
Copy link
Member Author

joccau commented Sep 23, 2024

/test pull-lightning-integration-test

Copy link

tiprow bot commented Sep 23, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joccau
Copy link
Member Author

joccau commented Sep 23, 2024

/test tidb_parser_test

Copy link

ti-chi-bot bot commented Sep 23, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test check-dev
  • /test check-dev2
  • /test mysql-test
  • /test pull-br-integration-test
  • /test pull-integration-ddl-test
  • /test pull-lightning-integration-test
  • /test pull-mysql-client-test
  • /test unit-test

The following commands are available to trigger optional jobs:

  • /test canary-notify-when-compatibility-sections-changed
  • /test pingcap/tidb/canary_ghpr_unit_test
  • /test pull-common-test
  • /test pull-e2e-test
  • /test pull-integration-common-test
  • /test pull-integration-copr-test
  • /test pull-integration-jdbc-test
  • /test pull-integration-mysql-test
  • /test pull-integration-nodejs-test
  • /test pull-sqllogic-test
  • /test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tidb/ghpr_build
  • pingcap/tidb/ghpr_check
  • pingcap/tidb/ghpr_check2
  • pingcap/tidb/ghpr_mysql_test
  • pingcap/tidb/ghpr_unit_test
  • pingcap/tidb/pull_br_integration_test
  • pingcap/tidb/pull_integration_ddl_test
  • pingcap/tidb/pull_lightning_integration_test
  • pingcap/tidb/pull_mysql_client_test

In response to this:

/test tidb_parser_test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Sep 23, 2024

/test pull-lightning-integration-test

Copy link

tiprow bot commented Sep 23, 2024

@joccau: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-lightning-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title ddl: refactor V2 args for RebaseAutoID DDL. ddl: refactor V2 args for RebaseAutoID/Modify-table/Index-visibility/FK related DDL. Sep 23, 2024
@D3Hunter D3Hunter mentioned this pull request Sep 23, 2024
55 tasks
Copy link

ti-chi-bot bot commented Sep 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 24, 2024
Copy link

ti-chi-bot bot commented Sep 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-23 07:18:59.16859336 +0000 UTC m=+1464008.909017299: ☑️ agreed by D3Hunter.
  • 2024-09-24 02:21:38.460717097 +0000 UTC m=+1532568.201141037: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 58bece3 into pingcap:master Sep 24, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants