Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: extract the common function to rebuild the queue #56251

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Sep 24, 2024

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

This pull request extracted a function for rebuilding the job queue, allowing us to reuse code to implement the new priority queue.

Check out https://github.com/pingcap/tidb/pull/55889/files#r1774853942 to see how we use it.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 68.26923% with 33 lines in your changes missing coverage. Please review.

Project coverage is 77.1190%. Comparing base (e87affb) to head (2869318).
Report is 59 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56251        +/-   ##
================================================
+ Coverage   73.4116%   77.1190%   +3.7074%     
================================================
  Files          1601       1641        +40     
  Lines        444010     470077     +26067     
================================================
+ Hits         325955     362519     +36564     
+ Misses        98086      86220     -11866     
- Partials      19969      21338      +1369     
Flag Coverage Δ
integration 53.5751% <0.0000%> (?)
unit 73.7145% <68.2692%> (+1.2387%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 61.8695% <ø> (+15.9832%) ⬆️

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 25, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
@Rustin170506 Rustin170506 changed the title WIP: statistics: extract the common function to rebuild the queue statistics: extract the common function to rebuild the queue Sep 25, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506
Copy link
Member Author

/retest

1 similar comment
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506
Copy link
Member Author

/retest

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-26 06:43:31.212828242 +0000 UTC m=+1721080.953252180: ☑️ agreed by AilinKid.
  • 2024-09-26 08:18:29.312623321 +0000 UTC m=+1726779.053047258: ☑️ agreed by time-and-fate.

@ti-chi-bot ti-chi-bot bot merged commit f75100c into pingcap:master Sep 26, 2024
24 checks passed
@Rustin170506 Rustin170506 deleted the rustin-patch-queue-common branch September 26, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants