Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: implement stats handler for DDL notifier part 2 #56519

Merged
merged 2 commits into from
Oct 10, 2024
Merged

stats: implement stats handler for DDL notifier part 2 #56519

merged 2 commits into from
Oct 10, 2024

Conversation

lance6716
Copy link
Contributor

@lance6716 lance6716 commented Oct 10, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #55722

Problem Summary:

What changed and how does it work?

port the handling logic of ActionAddColumn ActionModifyColumn ActionAddTablePartition ActionReorganizePartition ActionAlterTablePartitioning ActionRemovePartitioning ActionFlashbackCluster to DDL notifier subscriber.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test

    will test it after the publisher is ready

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lance6716
stats: implement stats handler for DDL notifier part 2
0a1b2a9 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@lance6716 lance6716 requested a review from fzzf678 October 10, 2024 03:43
@tiprow tiprow
Copy link

tiprow bot commented Oct 10, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented Oct 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Project coverage is 75.3618%. Comparing base (ffcfb5e) to head (2230f7d).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56519        +/-   ##
================================================
+ Coverage   73.3704%   75.3618%   +1.9913%     
================================================
  Files          1626       1648        +22     
  Lines        448978     457298      +8320     
================================================
+ Hits         329417     344628     +15211     
+ Misses        99381      91392      -7989     
- Partials      20180      21278      +1098
Flag Coverage Δ
integration 50.2776% <0.0000%> (?)
unit 72.5083% <0.0000%> (+0.0279%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.2579% <ø> (+6.6842%) ⬆️

@lance6716
port more
2230f7d 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 10, 2024
Rustin170506
Rustin170506 approved these changes Oct 10, 2024
View reviewed changes
pkg/statistics/handle/ddl/subscriber.go
@@ -180,6 +245,19 @@ func (h handler) delayedDeleteStats4PhysicalID(
return errors.Trace(h.recordHistoricalStatsMeta(ctx, sctx, id, startTS))
}

func (h handler) insertStats4Col(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func (h handler) insertStats4Col(
func (h handler) insertStats2Col(

The inner function used 2.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will rename it in next PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the inner function is "insert column to KV", not "insert for column". So I think 4 is OK

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzzf678, Rustin170506

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 10, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 10, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-10 06:04:06.500962073 +0000 UTC m=+1112401.921175083: ☑️ agreed by fzzf678.
  • 2024-10-10 06:10:05.600018496 +0000 UTC m=+1112761.020231506: ☑️ agreed by Rustin170506.

@ti-chi-bot ti-chi-bot bot merged commit 9b1fa1c into pingcap:master Oct 10, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@fzzf678 fzzf678 fzzf678 approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lance6716 @Rustin170506 @fzzf678