Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Global index plan cache tests #56588

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mjonss
Copy link
Contributor

@mjonss mjonss commented Oct 11, 2024

What problem does this PR solve?

Issue Number: ref #45133

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 11, 2024
@mjonss mjonss requested a review from Defined2014 October 11, 2024 12:44
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/planner SIG: Planner labels Oct 11, 2024
Copy link

tiprow bot commented Oct 11, 2024

Hi @mjonss. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5344%. Comparing base (55fadff) to head (ca5aca4).
Report is 291 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56588         +/-   ##
=================================================
- Coverage   73.2713%   57.5344%   -15.7370%     
=================================================
  Files          1626       1778        +152     
  Lines        448916     651309     +202393     
=================================================
+ Hits         328927     374727      +45800     
- Misses        99830     251322     +151492     
- Partials      20159      25260       +5101     
Flag Coverage Δ
integration 39.2468% <ø> (?)
unit 72.5162% <ø> (+0.0687%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 61.5433% <ø> (+16.0718%) ⬆️

@Defined2014
Copy link
Contributor

/retest

Copy link

tiprow bot commented Oct 16, 2024

@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mjonss
Copy link
Contributor Author

mjonss commented Oct 16, 2024

/retest

Copy link

tiprow bot commented Oct 16, 2024

@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@@ -3658,3 +3658,22 @@ func checkGlobalAndPK(t *testing.T, tk *testkit.TestKit, name string, indexes in
require.True(t, idxInfo.Primary)
}
}

func TestAdminCheckWithPartitions(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It similar with some admin check test cases in pkg/executor/test/admintest/admin_test.go. Maybe we can modify those cases directly instead of add a new one.

Copy link

ti-chi-bot bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Defined2014
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, rustin170506 for approval, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 17, 2024
Copy link

ti-chi-bot bot commented Oct 17, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-17 02:34:07.390409657 +0000 UTC m=+497644.539319483: ☑️ agreed by Defined2014.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants