-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Global index plan cache tests #56588
base: master
Are you sure you want to change the base?
Conversation
Hi @mjonss. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56588 +/- ##
=================================================
- Coverage 73.2713% 57.5344% -15.7370%
=================================================
Files 1626 1778 +152
Lines 448916 651309 +202393
=================================================
+ Hits 328927 374727 +45800
- Misses 99830 251322 +151492
- Partials 20159 25260 +5101
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
@Defined2014: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@mjonss: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@@ -3658,3 +3658,22 @@ func checkGlobalAndPK(t *testing.T, tk *testkit.TestKit, name string, indexes in | |||
require.True(t, idxInfo.Primary) | |||
} | |||
} | |||
|
|||
func TestAdminCheckWithPartitions(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It similar with some admin check
test cases in pkg/executor/test/admintest/admin_test.go
. Maybe we can modify those cases directly instead of add a new one.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Defined2014 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: ref #45133
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.