-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ttl: fix a wrong ttl's job schedule for TTL table upgraded from 6.5 (#56540) #56593
ttl: fix a wrong ttl's job schedule for TTL table upgraded from 6.5 (#56540) #56593
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #56593 +/- ##
================================================
Coverage ? 72.1150%
================================================
Files ? 1415
Lines ? 413004
Branches ? 0
================================================
Hits ? 297838
Misses ? 95267
Partials ? 19899
Flags with carried forward coverage won't be shown. Click here to find out more.
|
28e5ac1
to
ab5bcb6
Compare
ab5bcb6
to
3f71c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[LGTM Timeline notifier]Timeline:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, lcwangchao, YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #56540
What problem does this PR solve?
Issue Number: close #56539
Problem Summary:
In 6.5, the TTL table is created without meta
ttl_job_interval
, so after upgraded, theSCHED_POLICY_EXPR
inmysql.tidb_timers
is also empty that causing the frequent scheduling of TTL job.What changed and how does it work?
When syncing the timer, insert a default value if
ttl_job_interval
is emptyCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.