Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: rename queue files for consistency #56732

Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Oct 20, 2024

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

  1. Renamed queue_v2_xxx.go to queue_xxx.go. Because we only have one version now.
  2. Refactored FetchAllTablesAndBuildAnalysisJobs as a method of the priority queue.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 71.26866% with 154 lines in your changes missing coverage. Please review.

Project coverage is 56.9039%. Comparing base (e13bfeb) to head (a0c96f0).
Report is 29 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56732         +/-   ##
=================================================
- Coverage   73.3262%   56.9039%   -16.4224%     
=================================================
  Files          1630       1786        +156     
  Lines        450312     646607     +196295     
=================================================
+ Hits         330197     367945      +37748     
- Misses        99833     253880     +154047     
- Partials      20282      24782       +4500     
Flag Coverage Δ
integration 38.6749% <4.2910%> (?)
unit 72.8942% <71.2686%> (+0.4341%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5250% <ø> (+6.9362%) ⬆️

Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 force-pushed the rustin-patch-queue-v2-to-queue branch from 7151c3a to 1d64931 Compare October 21, 2024 02:47
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@Rustin170506
Copy link
Member Author

/retest

1 similar comment
@Rustin170506
Copy link
Member Author

/retest

Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>

fix

fix

fix
@Rustin170506 Rustin170506 force-pushed the rustin-patch-queue-v2-to-queue branch from a20b2e2 to a0c96f0 Compare October 22, 2024 07:03
Copy link
Member Author

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 Self-check (PR reviewed by myself and ready for feedback.)

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 22, 2024
Copy link
Contributor

@elsa0520 elsa0520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 23, 2024
Copy link

ti-chi-bot bot commented Oct 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-22 08:46:03.570435736 +0000 UTC m=+340764.267226339: ☑️ agreed by lance6716.
  • 2024-10-23 06:16:39.465255017 +0000 UTC m=+418200.162045622: ☑️ agreed by elsa0520.

Copy link

ti-chi-bot bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, elsa0520, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 48c57ce into pingcap:master Oct 23, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants