-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: fix flaky test by using t.TempDir #56737
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
/check-issue-triage-complete |
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56737 +/- ##
=================================================
- Coverage 73.3262% 56.4381% -16.8882%
=================================================
Files 1630 1756 +126
Lines 450312 631715 +181403
=================================================
+ Hits 330197 356528 +26331
- Misses 99833 251235 +151402
- Partials 20282 23952 +3670
Flags with carried forward coverage won't be shown. Click here to find out more.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: close #56735
Problem Summary:
What changed and how does it work?
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.