Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: collect at most NDV-1 TopN | tidb-test=pr/2420 #56820

Closed
wants to merge 2 commits into from

Conversation

terry1purcell
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #47400

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner labels Oct 24, 2024
Copy link

ti-chi-bot bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elsa0520 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 24, 2024
Copy link

tiprow bot commented Oct 24, 2024

Hi @terry1purcell. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 55.4639%. Comparing base (ed9a909) to head (6b47e0a).
Report is 148 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56820         +/-   ##
=================================================
- Coverage   73.2825%   55.4639%   -17.8186%     
=================================================
  Files          1636       1780        +144     
  Lines        453340     635809     +182469     
=================================================
+ Hits         332219     352645      +20426     
- Misses       100768     259577     +158809     
- Partials      20353      23587       +3234     
Flag Coverage Δ
integration 19.9650% <0.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 46.3511% <ø> (+0.3599%) ⬆️

@terry1purcell terry1purcell changed the title planner: collect at most NDV-1 TopN planner: collect at most NDV-1 TopN | tidb-test=pr/2420 Oct 24, 2024
Copy link

ti-chi-bot bot commented Oct 24, 2024

@terry1purcell: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 6b47e0a link true /test check-dev2
idc-jenkins-ci-tidb/mysql-test 6b47e0a link true /test mysql-test
idc-jenkins-ci-tidb/unit-test 6b47e0a link true /test unit-test
idc-jenkins-ci-tidb/check_dev 6b47e0a link true /test check-dev

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 7, 2024
@terry1purcell
Copy link
Contributor Author

Too many testcase changes

@terry1purcell terry1purcell deleted the topn branch December 19, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: zero estimation result if all values are in TopN
1 participant