Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obj storage: optimize azure reader #56852

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Oct 27, 2024

What problem does this PR solve?

Issue Number: ref #56606

Problem Summary:

What changed and how does it work?

replace open reader on every read by open reader once and read

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

read one 250M file, before 17s, after 395ms

  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 27, 2024
Copy link

tiprow bot commented Oct 27, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 57.0563%. Comparing base (0fca61c) to head (c63efc8).
Report is 16 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #56852         +/-   ##
=================================================
- Coverage   73.3131%   57.0563%   -16.2568%     
=================================================
  Files          1636       1786        +150     
  Lines        453635     640498     +186863     
=================================================
+ Hits         332574     365445      +32871     
- Misses       100683     249937     +149254     
- Partials      20378      25116       +4738     
Flag Coverage Δ
integration 39.3712% <0.0000%> (?)
unit 72.5032% <0.0000%> (-0.0184%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0887% <0.0000%> (+17.0465%) ⬆️

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2024
Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Oct 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2024
Copy link

ti-chi-bot bot commented Oct 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-27 04:58:12.979307144 +0000 UTC m=+153005.818462689: ☑️ agreed by lance6716.
  • 2024-10-27 05:55:04.25276754 +0000 UTC m=+156417.091923071: ☑️ agreed by GMHDBJD.

@ti-chi-bot ti-chi-bot bot merged commit 7292117 into pingcap:master Oct 27, 2024
40 of 49 checks passed
@D3Hunter D3Hunter deleted the opt-azure-reader branch October 27, 2024 13:28
@D3Hunter
Copy link
Contributor Author

/cherry-pick release-8.1-20241024-v8.1.1

@ti-chi-bot
Copy link
Member

@D3Hunter: new pull request created to branch release-8.1-20241024-v8.1.1: #56853.

In response to this:

/cherry-pick release-8.1-20241024-v8.1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Oct 27, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Oct 29, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #56938.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #56940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants