-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: add the refresher as a stats owner listener #56998
statistics: add the refresher as a stats owner listener #56998
Conversation
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #56998 +/- ##
=================================================
- Coverage 73.2196% 57.2302% -15.9894%
=================================================
Files 1650 1801 +151
Lines 455460 644306 +188846
=================================================
+ Hits 333486 368738 +35252
- Misses 101497 250307 +148810
- Partials 20477 25261 +4784
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for non-stats part
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, D3Hunter, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
What problem does this PR solve?
Issue Number: ref #55906
Problem Summary:
What changed and how does it work?
In this PR, I added the refresher as a listener for the stats owner, to ensure that after a stats owner changes, the background process can stop correctly.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.