Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: let TempIndex support encode/decode partitionID flag (#57017) #57075

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57017

What problem does this PR solve?

Issue Number: close #56535

Problem Summary: TempIndex didn't process partition handle before. So let it supports encode/decode partition handle.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.6742%. Comparing base (999befe) to head (5b9ccc0).
Report is 12 commits behind head on release-8.5.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release-8.5     #57075         +/-   ##
====================================================
- Coverage      73.2006%   56.6742%   -16.5265%     
====================================================
  Files             1652       1780        +128     
  Lines           456093     637496     +181403     
====================================================
+ Hits            333863     361296      +27433     
- Misses          101707     252028     +150321     
- Partials         20523      24172       +3649     
Flag Coverage Δ
integration 37.4582% <45.1612%> (?)
unit 72.8204% <83.8709%> (+0.3459%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.5937% <ø> (+6.5963%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 1, 2024
@Defined2014 Defined2014 requested a review from tangenta November 1, 2024 12:52
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 1, 2024
Copy link

ti-chi-bot bot commented Nov 1, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-01 12:49:48.836677747 +0000 UTC m=+613301.675833286: ☑️ agreed by Defined2014.
  • 2024-11-01 14:21:34.961488986 +0000 UTC m=+618807.800644530: ☑️ agreed by mjonss.

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Nov 4, 2024
@Defined2014
Copy link
Contributor

/retest

Copy link

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, mjonss, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 11, 2024
@Defined2014
Copy link
Contributor

/retest

1 similar comment
@Defined2014
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit ef73392 into pingcap:release-8.5 Nov 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants