-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: handle the prune mode correctly in the refresher #57096
statistics: handle the prune mode correctly in the refresher #57096
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57096 +/- ##
=================================================
- Coverage 73.2121% 57.2470% -15.9651%
=================================================
Files 1652 1809 +157
Lines 456143 653936 +197793
=================================================
+ Hits 333952 374359 +40407
- Misses 101669 254719 +153050
- Partials 20522 24858 +4336
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔢 Self-check (PR reviewed by myself and ready for feedback.)
100d379
to
15ead73
Compare
Signed-off-by: Rustin170506 <29879298+Rustin170506@users.noreply.github.com>
15ead73
to
e0ab534
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AilinKid, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In response to a cherrypick label: new pull request created to branch |
What problem does this PR solve?
Issue Number: close #57168
Problem Summary:
What changed and how does it work?
When checking the prune mode, we need to ensure that we have loaded the latest variable value. However, directly using the system session pool does not work, as it requires manual updates to obtain the latest global variable value.
In this PR, I utilized the session context from the caller that has already updated the session, allowing us to correctly retrieve the prune mode.
For earlier versions of TiDB, this issue did not occur because we did not use this session to retrieve the global variable in those versions.
Additionally, I added a test case for the queue to verify the handling of DML changes for partitioned tables.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.