-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log backup: set a proper maxVersion to resolve lock (#57178) #57281
log backup: set a proper maxVersion to resolve lock (#57178) #57281
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
/retest |
<<<<<<< HEAD | ||
======= | ||
func (p *mockPDClient) GetAllStores(ctx context.Context, opts ...pd.GetStoreOption) ([]*metapb.Store, error) { | ||
// only used for GetRegionCache once in resolve lock | ||
return []*metapb.Store{ | ||
{ | ||
Id: 1, | ||
Address: "127.0.0.1", | ||
}, | ||
}, nil | ||
} | ||
|
||
func (p *mockPDClient) GetClusterID(ctx context.Context) uint64 { | ||
return 1 | ||
} | ||
|
||
>>>>>>> 042846ecb16 (log backup: set a proper maxVersion to resolve lock (#57178)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines need to be fixed.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, BornChanger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.5 #57281 +/- ##
================================================
Coverage ? 72.1450%
================================================
Files ? 1417
Lines ? 413323
Branches ? 0
================================================
Hits ? 298192
Misses ? 95136
Partials ? 19995
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@ti-chi-bot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #57178
What problem does this PR solve?
Issue Number: close #57134
Problem Summary:
What changed and how does it work?
To minimize the risk of lock conflicts, set the maxVersion to be the largest existing version value across all slow regions, incremented by 1. This adjustment helps optimize RPO by proactively reducing lock contention.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.