expression: Fix optimizer panic in evaluate expr with null (#57403)

[ti-chi-bot]

This is an automated cherry-pick of #57403

What problem does this PR solve?

Issue Number: close #55886

Problem Summary:

What changed and how does it work?

1. Both evaluateExprWithNull and evaluateExprWithNullInNullRejectCheck use NewFunction instead of NewFunctionInternal to create a scalar function
2. let EvaluateExprWithNull return error if some error happens inside EvaluateExprWithNull
3. The caller of EvaluateExprWithNull need to decide how to handle this error, currently, all the callers of EvaluateExprWithNull are optimizer, and will ignore the error

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

[windtalker]

lgtm

[codecov]

Codecov Report

Attention: Patch coverage is 34.28571% with 46 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@0ab1f34). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #57517   +/-   ##
================================================
  Coverage               ?   57.0071%           
================================================
  Files                  ?       1770           
  Lines                  ?     626418           
  Branches               ?          0           
================================================
  Hits                   ?     357103           
  Misses                 ?     245180           
  Partials               ?      24135           

Flag	Coverage Δ
integration	36.8879% <30.0000%> (?)
unit	72.6692% <34.1463%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	52.4436% <0.0000%> (?)

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/expression/OWNERS [windtalker]
• pkg/planner/OWNERS [AilinKid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-19 11:44:49.276838148 +0000 UTC m=+961451.467707146: ☑️ agreed by windtalker.
• 2024-11-19 12:30:14.674696478 +0000 UTC m=+964176.865565469: ☑️ agreed by AilinKid.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[windtalker]

/test check-dev2

[tiprow]

@windtalker: No presubmit jobs available for pingcap/tidb@release-8.5

In response to this:

/test check-dev2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.