-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix count(*)
return wrong value for information_schema.tables
(#57506)
#57549
planner: fix count(*)
return wrong value for information_schema.tables
(#57506)
#57549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, hawkingrei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-8.5 #57549 +/- ##
================================================
Coverage ? 56.8208%
================================================
Files ? 1770
Lines ? 625980
Branches ? 0
================================================
Hits ? 355687
Misses ? 246236
Partials ? 24057
Flags with carried forward coverage won't be shown. Click here to find out more.
|
/retest |
This is an automated cherry-pick of #57506
What problem does this PR solve?
Issue Number: close #56987
Problem Summary:
InfoSchemaBaseExtractor
wrongly filter table names for the fast path introduced by #55574What changed and how does it work?
Introduce a new variable
extractLowerString
to dertermine whether to do case-insensitive comparisons for specific columns.Test case is not added in integration test because we don't want to write some hardcoded value. (ref #57306)
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.