Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics: fix some problem related to stats async load (#57723) #57774

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #57723

What problem does this PR solve?

Issue Number: close #57722, close #57735

Problem Summary:

What changed and how does it work?

Version0 means that column stats is not created via the ANALYZE command. We should not use it to update the Last Analyze Timestamp.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

修复没有收集过统计信息的表的上次 ANALYZE 时间可能不为 NULL 的问题
Fix the issue that an unanalyzed table's last analyze time may not be NULL.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR. labels Nov 27, 2024
@winoros winoros force-pushed the cherry-pick-57723-to-release-8.1 branch from fc8e356 to f9a50cc Compare December 3, 2024 09:44
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
@winoros winoros force-pushed the cherry-pick-57723-to-release-8.1 branch from f9a50cc to 8d54926 Compare December 3, 2024 12:23
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: time-and-fate, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 3, 2024
Copy link

ti-chi-bot bot commented Dec 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-03 11:56:46.135032958 +0000 UTC m=+1155993.754687473: ☑️ agreed by time-and-fate.
  • 2024-12-03 12:56:48.431447534 +0000 UTC m=+1159596.051102044: ☑️ agreed by winoros.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.1@e2da796). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #57774   +/-   ##
================================================
  Coverage               ?   71.1892%           
================================================
  Files                  ?       1467           
  Lines                  ?     423411           
  Branches               ?          0           
================================================
  Hits                   ?     301423           
  Misses                 ?     101468           
  Partials               ?      20520           
Flag Coverage Δ
unit 71.1892% <80.9523%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.2954% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot merged commit 8e150a5 into pingcap:release-8.1 Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.1 This PR is cherry-picked to release-8.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants