ddl: Fixed partitioning a non-partitioned table with placement rules (#57560)

[ti-chi-bot]

This is an automated cherry-pick of #57560

What problem does this PR solve?

Issue Number: close #55705

Problem Summary:
When updating the placement rule bundle, the table ID was included both as the table and the partition id.

What changed and how does it work?

Not adding it as partition id for non-partitioned table (which uses the original table as a single partition, hence the same ID).

Also simplified the bundle handling during schema update / ApplyDiff, by removing logic that:

• first went through all partitions and marked the partition to update the bundle, then went through all partition updates and updated its table

to

• mark the table directly that it should update the bundle.

For REORGANIZE PARTITION, there the bundles will be updated twice, first with the intermediate set of partitions (both old and new), so that data copying and index creations on the new partitions will follow the correct policies directly, and then with the final partition set, avoiding having to move the data again when the DDL is done.

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

fixed an issue with partitioning a non-partitioned table with placement rules.

[codecov]

Codecov Report

Attention: Patch coverage is 77.98165% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-8.5@64ce2c0). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5     #57811   +/-   ##
================================================
  Coverage               ?   56.8894%           
================================================
  Files                  ?       1770           
  Lines                  ?     626744           
  Branches               ?          0           
================================================
  Hits                   ?     356551           
  Misses                 ?     246050           
  Partials               ?      24143           

Flag	Coverage Δ
integration	36.8443% <61.4678%> (?)
unit	72.5396% <77.9816%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.9478% <0.0000%> (?)
parser	∅ <0.0000%> (?)
br	52.2971% <0.0000%> (?)

[bb7133]

LGTM

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-29 01:26:06.391415403 +0000 UTC m=+772554.011069916: ☑️ agreed by mjonss.
• 2024-11-29 07:11:04.828294824 +0000 UTC m=+793252.447949341: ☑️ agreed by bb7133.

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bb7133, mjonss, wjhuang2016

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/ddl/OWNERS [wjhuang2016]
• pkg/domain/OWNERS [wjhuang2016]
• pkg/infoschema/OWNERS [wjhuang2016]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mjonss]

/retest